Singleton -- Obviously (hard to test, can you guarantee behaviour of VMs and ClassLoaders?,...)
Extends Thread -- Use runnable it's easier to test
I've found 15 self starting threads which are actually singletons aswell! Do I get a prize. --OliBye
junit.swingui.TestRunner.doRunTest() has an anonymous inner class that extends Thread in-place. Um... cool? Hmm. Jury's still out. --DarrenH
Abstracting to hell -- Too much too soon! (it's not big and it's not clever)
Blob/God -- 'nuff said
Unclear responsibility -- One class does one thing or is one thing
Instantiating classes without fulfilling prerequisites -- Constructing a class and then always having to call setSomething before it's usable, happens a lot with Singleton.
Unclear actions e.g. self starting threads -- magic is bad
catch(Exception e){} -- invisibility is bad, where did it go?
Code which adds nothing -- Impossible to test and clutters things up -- See Abstracting to hell
Duplicate code -- I really don't want to have to type or read things more than once
Declaring to throw Exception -- There's not much I can do unless I know what went wrong
myThing -- There must be a better name for this variable
Static initialisers -- Rather difficult to test, more Magic (the VM pixies at work)
System.exit(0); -- Makes reuse difficult
Non final static variables -- Can you say Global variable
Magic numbers -- Use constants or look at the size of something
Literal strings -- Use constants, espetially if you can't spell
Using return codes -- If it's an error throw an Exception
Not writing Javadoc as you go -- Much better to write when you know what the class does rather than when you've forgotten.
Writing Javadoc as you go -- If someone reading you code needs a gloss to understand it, re-write it so that they don't.
Comments in methods -- Chances are you'd be better splitting the code out into another method.
The CLASSPATH enviroment variable
.toString() -- Whats that for? Is it a description or a serialisation? 'its for debugging'
Too much beer -- especially the morning after the night before
EvilThings